Allow topo::Builder::with_tips and with_ends for non-default pred
#1720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently introduced the associated fns `with_tips` and `with_ends` for adding tips and ends after initial creation of a `Builder`. We erroneously added them to the one impl constraining the predicate to a specific function pointer type for the default predicate. This meant that tips and ends could only be added until the predicate is set to a `FnMut` that can not be coerced to that same type. This change lifts this limitation by moving `with_tips` and `with_ends` to the more generic impl for `Builder`.
Byron
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently (in #1716) introduced the associated fns
with_tipsandwith_endsfor adding tips and ends after initial creation of aBuilder. We erroneously added them to the one impl constraining the predicate to a specific function pointer type for the default predicate. This meant that tips and ends could only be added until the predicate is set to aFnMutthat can not be coerced to that same type.This change lifts this limitation by moving
with_tipsandwith_endsto the more generic impl forBuilder.--
Sorry for the noise. I should have paid more attention where I put those functions. Btw: the rationale for this change also holds for
with_predicateimo. Typically users will only set a predicate once and not change it afterwards, but it doesn't exactly hurt to have it in the impl generic overPredicate.