Add test for commits not ordered chronologically #1823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Byron
approved these changes
Feb 1, 2025
There was a problem hiding this comment.
That's wonderful, and I should really keep an eye out for the topo-order !+date-order case myself.
It's something to keep in mind when implementing any kind of traversal for sure. The main problem about traversals for me certainly is that I forget everything about them very quickly.
Regarding test-organization, I think it's up to your preference. I keep finding myself working with possibly big and ever-growing 'thematic' fixtures. And since the theme here is blame, and the test-cases seem to be nicely isolated despite sharing a single repository, tree and commit-graph, I'd not change a thing.
In fact, it's probably great to have a complex commit-graph to lure out strange bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test covers a case that I came across working on #1743. Git doesn’t guarantee commits are ordered by commit date, so this adds a test for that specific case. In order to facilitate review, I decided to go with this small and targeted PR.
Since I keep adding tests to
make_blame_repo.sh, I started wondering whether this was the best way of organizing the different test cases or whether it would be beneficial to spread them across multiple smaller files. What do you think?