Fix a few ShellCheck warnings and stylistic inconsistencies #1908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was originally intended to be part of much broader changes, to more scripts, along the same lines, and adding a ShellCheck CI job. That will likely still happen, but it's not clear when it will get done. Rather than wait, this brings in the small benefits of these changes.
This was regenerated via `cargo nextest --workspace --no-fail-fast` and verifying that there were no failures, then committing the one changed file, on an Arch Linux system with Git 2.49.0. This is the only tracked archive that changes due to the script changes in the previous commit. The other changed scripts are either to scripts whose generated archives are `.gitignore`d, or to scripts that are not fixture scripts (so no archives at all).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally intended to be part of much broader changes, to more scripts, along the same lines, and adding a ShellCheck CI job. That will likely still happen, but it's not clear when it will get done. Rather than wait, this brings in the small benefits of these changes.