Skip to content

Add Either::tree_id #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2025
Merged

Conversation

cruessler
Copy link
Contributor

  • Add Either::tree_id
  • Use Either::tree_id in gix-blame

This is based on a suggestion in this comment: #1824 (comment).

@Byron Byron force-pushed the add-tree-id-to-either branch from 408d219 to 3fad860 Compare March 24, 2025 00:42
@Byron Byron enabled auto-merge March 24, 2025 00:42
@Byron
Copy link
Member

Byron commented Mar 24, 2025

Thanks a lot, a great catch!

While rushing over it I kind of caused a blunder: I essentially ended up editing your commit messages (to assure it gets into the changelog) without really thinking about the implication: I changed your words.
This could be an issue in principle and is nothing I really want to do, but I guess I just wanted to be done with the PR without having to send it into a review iteration.

Please let me know if these kinds of small changes are in your interest or not - if not I will not do that again but rather ask you to change commit messages.

PS: To never have me change your commits, you could sign them - naturally I don't destroy peoples signatures 😅.

@Byron Byron merged commit 544cdaf into GitoxideLabs:main Mar 24, 2025
21 checks passed
@cruessler
Copy link
Contributor Author

Please let me know if these kinds of small changes are in your interest or not - if not I will not do that again but rather ask you to change commit messages.

I’m completely fine with you also changing commit messages! I’m always trying to match existing conventions, so this is helpful feedback, but I prefer if it does not block progress on a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants