feat: add support for asyncpg driver #390
Conversation
jackwotherspoon
changed the title
| connector = await create_async_connector() | ||
|
|
||
| # create connection to Cloud SQL database | ||
| conn: asyncpg.Connection = await connector.connect_async( |
There was a problem hiding this comment.
nit: this connection should probably use an async with
There was a problem hiding this comment.
the connector or connection itself? async with create_async_connector() or async with connector.connect_async(...) ?
There was a problem hiding this comment.
The connection itself.
Do we support async enters and exit with the Connector?
There was a problem hiding this comment.
not currently, we don't have an __aenter__ or __aexit__ implemented.
There was a problem hiding this comment.
I added the ability to create an async context manager with Connector and added example to README. I can't use async with for the connection because the asyncpg.Connection class does not have an __aenter__ or __aexit__. We could potentially create a Connection wrapper class of our own to implement an async context manager for the database connection. (Example). However, if in a future PR we are going to support connection pools (either through SQLAlchemy or native asyncpg.Pool then they will have context manager built in so not sure it is worth it to create the wrapper class.
There was a problem hiding this comment.
Ok, this is surprising to me that they don't support those two functions. I think it's fine to leave for now (maybe worth asking why they haven't?)
There was a problem hiding this comment.
Seems like there is an open issue for it actually, if I have some spare time I will try and put up another PR to asyncpg and add the two functions.
| connector = await create_async_connector() | ||
|
|
||
| # create connection to Cloud SQL database | ||
| conn: asyncpg.Connection = await connector.connect_async( |
There was a problem hiding this comment.
Ok, this is surprising to me that they don't support those two functions. I think it's fine to leave for now (maybe worth asking why they haven't?)
Todo:
Determine how to use creator argument or similar for SQLAlchemycreate_async_engineCloses #218