Skip to content

chore(deps): update dependency torch to v2.6.0 [security] - autoclosed #13391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

renovate-bot
Copy link
Contributor

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
torch ==2.2.2 -> ==2.6.0 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2025-32434

Description

I found a Remote Command Execution (RCE) vulnerability in PyTorch. When loading model using torch.load with weights_only=True, it can still achieve RCE.

Background knowledge

https://github.com/pytorch/pytorch/security
As you can see, the PyTorch official documentation considers using torch.load() with weights_only=True to be safe.
image
Since everyone knows that weights_only=False is unsafe, so they will use the weights_only=True to mitigate the seucirty issue.
But now, I just proved that even if you use weights_only=True, it can still achieve RCE.

Credit

This vulnerability was found by Ji'an Zhou.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate-bot renovate-bot requested review from a team as code owners May 28, 2025 12:15
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 28, 2025
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label May 28, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello! gemini-code-assist here, providing a summary of this pull request. This PR, automatically generated by renovate-bot, aims to update the torch dependency from version 2.2.2 to 2.6.0. The primary motivation for this update is to address a recently disclosed security vulnerability (CVE-2025-32434) in PyTorch related to the torch.load function, even when used with weights_only=True. The changes involve updating the version specification in the requirements.txt file used in the dataflow/run-inference example.

Highlights

  • Dependency Update: Updates the torch library dependency.
  • Version Bump: Bumps the torch version from 2.2.2 to 2.6.0.
  • Security Fix: The update is specifically for security reasons, addressing CVE-2025-32434, a vulnerability in torch.load.

Changelog

  • dataflow/run-inference/requirements.txt
    • Updated the specified version of the torch dependency from ==2.2.2 to ==2.6.0.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Dependencies shift,
Security needs a lift,
Code stays safe and swift.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the torch dependency from version 2.2.2 to 2.6.0. This is an important and welcome update as it addresses the security vulnerability CVE-2025-32434, described as a Remote Command Execution (RCE) risk associated with torch.load even when weights_only=True is specified.

The new version 2.6.0 incorporates the necessary patch for this vulnerability (which was fixed in torch 2.3.0 and later versions). The change is confined to the requirements.txt file and is a straightforward version bump. Given the critical nature of the security vulnerability being addressed, this update is highly recommended.

Summary of Findings

  • Security Vulnerability Mitigation: This pull request successfully updates the torch dependency to v2.6.0. This version change is critical as it mitigates the Remote Command Execution (RCE) vulnerability identified by CVE-2025-32434.
  • Code Change Quality: No new issues of medium, high, or critical severity were identified in the specific code changes introduced by this pull request (i.e., the version update in requirements.txt). The change is precise and directly addresses the intended dependency upgrade.

Merge Readiness

This pull request consists of a crucial security update by upgrading the torch library. The change itself is minimal and correctly applies the version bump. Assuming all continuous integration checks and relevant tests pass successfully, this PR appears ready for merging. While I cannot approve the PR as a reviewer, I strongly recommend its merge to improve the application's security posture. It would be prudent to ensure that any project-specific integration tests for torch 2.6.0 compatibility are green before finalizing the merge.

@renovate-bot renovate-bot force-pushed the renovate/pypi-torch-vulnerability branch from c899ced to 56fff3f Compare May 29, 2025 08:35
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 29, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 29, 2025
@renovate-bot renovate-bot force-pushed the renovate/pypi-torch-vulnerability branch from 56fff3f to 7436775 Compare May 29, 2025 21:01
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 29, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 29, 2025
@renovate-bot renovate-bot force-pushed the renovate/pypi-torch-vulnerability branch from 7436775 to 15668e7 Compare May 30, 2025 08:37
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 30, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 30, 2025
@renovate-bot renovate-bot changed the title chore(deps): update dependency torch to v2.6.0 [security] chore(deps): update dependency torch to v2.6.0 [security] - autoclosed May 31, 2025
@renovate-bot renovate-bot deleted the renovate/pypi-torch-vulnerability branch May 31, 2025 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
owlbot:run Add this label to trigger the Owlbot post processor. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants