Depend on the source headers directly #1587

ZzEeKkAa · 2024-03-08T14:30:44Z

Update CMake configuration and headers to use better target dependencies. It will unblock incremental compilation and flexible dependency management.

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
If this PR is a work in progress, are you opening the PR as a draft?

github-actions · 2024-03-12T00:03:48Z

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

github-actions · 2024-03-12T00:07:31Z

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_108 ran successfully.
Passed: 906
Failed: 0
Skipped: 94

github-actions · 2024-03-12T00:14:15Z

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_108 ran successfully.
Passed: 906
Failed: 0
Skipped: 94

github-actions · 2024-03-12T01:12:49Z

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_108 ran successfully.
Passed: 906
Failed: 0
Skipped: 94

github-actions · 2024-03-12T04:01:02Z

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_108 ran successfully.
Passed: 906
Failed: 0
Skipped: 94

github-actions · 2024-03-12T05:26:05Z

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_109 ran successfully.
Passed: 906
Failed: 0
Skipped: 94

github-actions · 2024-03-14T19:11:21Z

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_113 ran successfully.
Passed: 905
Failed: 1
Skipped: 94

github-actions · 2024-03-14T19:13:23Z

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_114 ran successfully.
Passed: 905
Failed: 1
Skipped: 94

github-actions · 2024-03-14T20:58:43Z

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_115 ran successfully.
Passed: 905
Failed: 1
Skipped: 94

coveralls · 2024-03-14T22:21:34Z

coverage: 87.832%. remained the same
when pulling 1757afe on feature/include_from_source
into 80f4f30 on master.

github-actions · 2024-03-14T22:40:28Z

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_123 ran successfully.
Passed: 905
Failed: 1
Skipped: 94

oleksandr-pavlyk · 2024-03-15T00:18:12Z

Increase in coverage is due to disappearence of Cython files from coverage.

This issue must resolved before the PR can be merged.

We need to understand whether the regression is due to changes of build script or due to upgrade from Cython 3.0.8 to Cuthon 3.0.9 that happened since the PR was first opened.

oleksandr-pavlyk · 2024-03-15T14:00:25Z

gh-1586 does not exhibit changes in coverage metrics despite also using Cython 3.0.9.

I also checked that C++ code generated by Cython did not materially change between versions.

Thus the change is caused by build system reorg.

oleksandr-pavlyk · 2024-03-15T14:05:38Z

This message emitted while processing .coverage database points to a problem:

Source file is not python /home/runner/work/dpctl/dpctl/dpctl/_diagnostics.pyx

ZzEeKkAa · 2024-03-15T16:17:01Z

May it be because we don't copy headers/cpp files of cython to source directory and they are always in build directory now?

This is blog by Stefan Behnel, maintainer of Cython, http://blog.behnel.de/posts/coverage-analysis-for-cython-modules.html

oleksandr-pavlyk · 2024-03-16T03:35:54Z

May it be because we don't copy headers/cpp files of cython to source directory and they are always in build directory now?

Yes, indeed. See http://blog.behnel.de/posts/coverage-analysis-for-cython-modules.html

I have pushed changes to copy CXX files into layout for coverage builds.

github-actions · 2024-03-16T04:06:47Z

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_127 ran successfully.
Passed: 906
Failed: 0
Skipped: 94

github-actions · 2024-03-16T13:41:25Z

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_128 ran successfully.
Passed: 906
Failed: 0
Skipped: 94

oleksandr-pavlyk

Thank you for getting this done @ZzEeKkAa ! Looks good to me now!

oleksandr-pavlyk · 2024-03-16T15:36:59Z

Testing clean building with and without use of lld, using

/usr/bin/time -f "%P %M %E" python scripts/build_locally.py --verbose

outputs are, on my WSL machine,

with lld
641% 3953024 20:24.33

with default linker
632% 4048804 20:59.47

ndgrigorian

I have also tested building this branch locally and it worked fine, so LGTM

oleksandr-pavlyk · 2024-03-17T12:25:11Z

I have checked locally that dpnp build continues working as expected.

antonwolfy · 2024-03-18T16:09:06Z

I can also confirm that dpnp build works with that PR without any issue.

oleksandr-pavlyk mentioned this pull request Mar 9, 2024

Cmake incremental builds improvement #1586

Closed

6 tasks

ZzEeKkAa force-pushed the feature/include_from_source branch 2 times, most recently from 5d493d4 to efc9d89 Compare March 11, 2024 23:17

ZzEeKkAa marked this pull request as ready for review March 11, 2024 23:17

ZzEeKkAa self-assigned this Mar 11, 2024

ZzEeKkAa requested a review from oleksandr-pavlyk March 11, 2024 23:17

ZzEeKkAa force-pushed the feature/include_from_source branch 4 times, most recently from 8fe19a1 to be87cbf Compare March 11, 2024 23:30

ZzEeKkAa force-pushed the feature/include_from_source branch from be87cbf to 474d6b0 Compare March 12, 2024 00:25

ZzEeKkAa force-pushed the feature/include_from_source branch from 474d6b0 to 0cdb12d Compare March 12, 2024 03:14

ZzEeKkAa force-pushed the feature/include_from_source branch from ee34da3 to bbf6c31 Compare March 14, 2024 18:21

ZzEeKkAa added 5 commits March 14, 2024 17:42

Use ldd linker

4055744

Organize sycl interface test CMakeList.txt

1eb17ec

Move syclinterface headers into subfolder

6a9f9b0

Update relative position of libsyclinterface include files

f6f666a

Remove relative path include in capi

d1288ac

ZzEeKkAa force-pushed the feature/include_from_source branch from dabcc36 to d08e2f1 Compare March 14, 2024 21:43

ZzEeKkAa added 2 commits March 14, 2024 17:52

Use library dependency in CMake

c5b7494

Update headers path in package data

6f83a43

ZzEeKkAa force-pushed the feature/include_from_source branch from d08e2f1 to 6f83a43 Compare March 14, 2024 21:52

ZzEeKkAa changed the title ~~WIP: depend on the source headers~~ Depend on the source headers Mar 14, 2024

ZzEeKkAa changed the title ~~Depend on the source headers~~ Depend on the source headers directly] Mar 14, 2024

ZzEeKkAa changed the title ~~Depend on the source headers directly]~~ Depend on the source headers directly Mar 14, 2024

oleksandr-pavlyk added 4 commits March 15, 2024 16:21

Fix spacing

98fd0d3

When building for coverage, ensure CXX are installed next to PYX

8ca5ead

This is blog by Stefan Behnel, maintainer of Cython, http://blog.behnel.de/posts/coverage-analysis-for-cython-modules.html

For Cython sources that are built as SYCL, use no-use-sycl-footer

bdb3a5c

Add comment around setting CYTHON_FLAGS variable

508a45e

Add subfolders from libtensor/include/kernels to package_data

1757afe

oleksandr-pavlyk approved these changes Mar 16, 2024

View reviewed changes

oleksandr-pavlyk requested review from ndgrigorian and antonwolfy March 16, 2024 15:00

ndgrigorian approved these changes Mar 16, 2024

View reviewed changes

antonwolfy approved these changes Mar 18, 2024

View reviewed changes

oleksandr-pavlyk merged commit 1fac073 into master Mar 18, 2024

oleksandr-pavlyk deleted the feature/include_from_source branch March 18, 2024 16:18

Depend on the source headers directly #1587

Depend on the source headers directly #1587

Uh oh!

Conversation

ZzEeKkAa commented Mar 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 12, 2024

Uh oh!

github-actions bot commented Mar 12, 2024

Uh oh!

github-actions bot commented Mar 12, 2024

Uh oh!

github-actions bot commented Mar 12, 2024

Uh oh!

github-actions bot commented Mar 12, 2024

Uh oh!

github-actions bot commented Mar 14, 2024

Uh oh!

github-actions bot commented Mar 14, 2024

Uh oh!

github-actions bot commented Mar 14, 2024

Uh oh!

coveralls commented Mar 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 14, 2024

Uh oh!

oleksandr-pavlyk commented Mar 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oleksandr-pavlyk commented Mar 15, 2024

Uh oh!

oleksandr-pavlyk commented Mar 15, 2024

Uh oh!

ZzEeKkAa commented Mar 15, 2024

Uh oh!

oleksandr-pavlyk commented Mar 16, 2024

Uh oh!

github-actions bot commented Mar 16, 2024

Uh oh!

github-actions bot commented Mar 16, 2024

Uh oh!

oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

Uh oh!

oleksandr-pavlyk commented Mar 16, 2024

Uh oh!

ndgrigorian left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oleksandr-pavlyk commented Mar 17, 2024

Uh oh!

antonwolfy commented Mar 18, 2024

Uh oh!

Uh oh!

ZzEeKkAa commented Mar 8, 2024 •

edited

Loading

github-actions bot commented Mar 12, 2024 •

edited

Loading

coveralls commented Mar 14, 2024 •

edited

Loading

oleksandr-pavlyk commented Mar 15, 2024 •

edited

Loading

ndgrigorian left a comment •

edited

Loading