Skip to content

Add implementation of dpnp.gcd and dpnp.lcm functions #2091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 9, 2024
Merged

Add implementation of dpnp.gcd and dpnp.lcm functions #2091

merged 8 commits into from
Oct 9, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Oct 7, 2024 •
edited
Loading

The PR proposes to add implementation of dpnp.gcd and dpnp.lcm functions.

The new dedicated _gcd and _lcm functions are added to _ufunc_impl pybind11 extension.
All the required tests are implemented to cover the new functions.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Oct 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy changed the title Impl gcd lcm Add implementation of dpnp.gcd and dpnp.lcm functions Oct 7, 2024
@antonwolfy antonwolfy marked this pull request as ready for review October 7, 2024 14:59
vlad-perevezentsev
vlad-perevezentsev approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit c4677e9 into master Oct 9, 2024
42 checks passed
@antonwolfy antonwolfy deleted the impl-gcd-lcm branch October 9, 2024 09:51
github-actions bot added a commit that referenced this pull request Oct 9, 2024
@github-actions
Add implementation of dpnp.gcd and dpnp.lcm functions (#2091)
a09c12c 
* Add gcd and lcm implementations to ufunc

* Add gcd and lcm functions to mathematical interface

* Add CFD tests

* Add third party tests

* Add more tests

* Update description of input arrays c4677e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vlad-perevezentsev