Add implementation of `dpnp.matrix_transpose()` and .`mT` attribute for dpnp.array #2095

vlad-perevezentsev · 2024-10-08T15:05:04Z

This PR suggests adding new implementation of dpnp.matrix_transpose() function and new .mT attribute for dpnp.array that was implemented in Numpy 2.0.

This function is Array API compatible:

array_api_tests/test_linalg.py::test_matrix_transpose PASSED

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
If this PR is a work in progress, are you filing the PR as a draft?

github-actions · 2024-10-08T15:23:28Z

View rendered docs @ https://intelpython.github.io/dpnp/index.html

vtavana · 2024-10-09T16:28:06Z

There is also numpy.linalg.matrix_tranpose in NumPy 2.0. Could you add it in this PR as well?

dpnp/dpnp_array.py

dpnp/dpnp_iface_manipulation.py

tests/test_linalg.py

tests/test_ndarray.py

dpnp/linalg/dpnp_iface_linalg.py

dpnp/dpnp_iface_manipulation.py

dpnp/linalg/dpnp_iface_linalg.py

vtavana

Thank you, @vlad-perevezentsev!

dpnp/dpnp_array.py

dpnp/dpnp_iface_manipulation.py

dpnp/linalg/dpnp_iface_linalg.py

dpnp/dpnp_iface_manipulation.py

antonwolfy

Thank you @vlad-perevezentsev

…or dpnp.array (#2095) * Add implementaion of dpnp.matrix_transpose() * Add TestMatrixtranspose to dpnp tests * Add .mT attribute for ndarray * Add tests for .mT arrribute * Add matrix_transpose() for dpnp.linalg module * Add test for dpnp.linalg.matrix_transpose() * Expand docs for .mT attribute * Reuse dpctl for matrix_transpose * Update dpnp.matrix_transpose() --------- Co-authored-by: Anton <[email protected]>

vlad-perevezentsev added 4 commits October 8, 2024 14:13

Add implementaion of dpnp.matrix_transpose()

4b640de

Add TestMatrixtranspose to dpnp tests

b737d1c

Add .mT attribute for ndarray

0c5db41

Add tests for .mT arrribute

7e0a38c

vlad-perevezentsev self-assigned this Oct 8, 2024

vlad-perevezentsev requested review from antonwolfy, npolina4 and vtavana as code owners October 8, 2024 15:05

vlad-perevezentsev added 4 commits October 10, 2024 12:25

Add matrix_transpose() for dpnp.linalg module

5fb2311

Add 'Other matrix operation' section to linalg docs

57687bd

Add test for dpnp.linalg.matrix_transpose()

6e51116

Merge master into impl_matrix_transpose

67ffb48

vtavana reviewed Oct 10, 2024

View reviewed changes

vlad-perevezentsev added 3 commits October 11, 2024 11:45

Expand docs for .mT attribute

2c5a935

Apply review remarks

86d18f2

Merge master into impl_matrix_transpose

6d1757c

vtavana approved these changes Oct 11, 2024

View reviewed changes