Add implementation of dpnp.i0
#2118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
requested review from
npolina4,
vlad-perevezentsev and
vtavana
as code owners
vtavana
reviewed
Oct 23, 2024
vtavana
approved these changes
Oct 23, 2024
github-actions bot
added a commit
that referenced
this pull request
Nov 15, 2024
* Implement dpnp.i0 function * Add sycl::half type to matrix * Add third party test * Add more tests * Add CFD tests * Remove redundant code for i0 kernel * Fix typo in docstring * Add tests with NaN and Inf values * Add a proper math include based on compiler version * Define proper DPC++ version where sycl::ext::intel::math::cyl_bessel_i0(x) works --------- Co-authored-by: vtavana <[email protected]> 0e50556
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR proposes to add implementation of
dpnp.i0function.The new dedicated
_i0function are added to_ufunc_implpybind11 extension.All the required tests are implemented to cover the new functions.
Note that SYCL kernel for the elementwise function assumes to call
sycl::ext::intel::math::cyl_bessel_i0where possible or to rely on own implementation based on source from gcc repo.