Skip to content

Use group_load_store compiler extension #2123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 13, 2024
Merged

Use group_load_store compiler extension #2123

merged 8 commits into from
Nov 13, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Oct 23, 2024 •
edited
Loading

The PR switches to group_load_store experimental extension per deprecation warning for 2025.1 DPC++ compiler.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Oct 23, 2024
@antonwolfy antonwolfy marked this pull request as draft October 23, 2024 19:45
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy marked this pull request as ready for review November 8, 2024 10:41
vtavana
vtavana approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit 078d9a3 into master Nov 13, 2024
45 of 46 checks passed
@antonwolfy antonwolfy deleted the resolve-cmpl-warning branch November 13, 2024 19:04
github-actions bot added a commit that referenced this pull request Nov 13, 2024
@github-actions
Use group_load_store compiler extension (#2123)
e505852 
* Use group_load_store compiler extension

* Tune description of dpnp.bincount 078d9a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vtavana