Skip to content

add rtol kwarg to dpnp.linalg.pinv and dpnp.linalg.matrix_rank #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 28, 2024
Merged

add rtol kwarg to dpnp.linalg.pinv and dpnp.linalg.matrix_rank #2124

merged 6 commits into from
Oct 28, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Oct 24, 2024

In this PR, rtol kwarg is added to dpnp.linalg.pinv and dpnp.linalg.matrix_rank to align with NumPy 2.0.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Oct 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 24, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review October 25, 2024 01:59
@vtavana vtavana force-pushed the update_linalg_functions branch from 2288843 to 271fc6c Compare October 25, 2024 02:15
antonwolfy
antonwolfy reviewed Oct 25, 2024
View reviewed changes
antonwolfy
antonwolfy approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana

@antonwolfy antonwolfy merged commit e8f348b into master Oct 28, 2024
46 checks passed
@antonwolfy antonwolfy deleted the update_linalg_functions branch October 28, 2024 23:53
github-actions bot added a commit that referenced this pull request Oct 29, 2024
@github-actions
add rtol kwarg to dpnp.linalg.pinv and dpnp.linalg.matrix_rank (#…
dd7cbb7 
…2124)

* add rtol keyword argument to dpnp.linalg.pinv and dpnp.linalg.matrix_rank

* address comments e8f348b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy