Skip to content

Leverage on dpctl.tensor implementation in dpnp.put_along_axis #2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 1, 2024
Merged

Leverage on dpctl.tensor implementation in dpnp.put_along_axis #2134

merged 5 commits into from
Nov 1, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Oct 29, 2024 •
edited
Loading

The PR proposes to leverage on dpctl.tensor implementation in dpnp.put_along_axis function.
Additionally, the function signature is extended with new keyword mode to provide a control how out-of-bounds indices will be handled.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Oct 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy marked this pull request as ready for review October 30, 2024 11:07
vtavana
vtavana approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit 2c4f3b5 into master Nov 1, 2024
45 of 46 checks passed
@antonwolfy antonwolfy deleted the dpctl-put_along_axis branch November 1, 2024 00:13
github-actions bot added a commit that referenced this pull request Nov 1, 2024
@github-actions
Leverage on dpctl.tensor implementation in dpnp.put_along_axis (#2134)
c2803af 
* Implement dpnp.put_along_axis through dpctl.tensor

* Increase test coverage

* Update dpnp/dpnp_iface_indexing.py

Co-authored-by: vtavana <[email protected]>

* Add empty lines per review comment

---------

Co-authored-by: vtavana <[email protected]> 2c4f3b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vtavana