Skip to content

add support for kwarg ndmin for dpnp.array #2135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 30, 2024
Merged

add support for kwarg ndmin for dpnp.array #2135

merged 4 commits into from
Oct 30, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Oct 29, 2024

In this PR, support for ndmin kwarg is added for dpnp.array , new tests are added and cupy tests are updated to include relevant test cases.
In addition, test classes in test_manipulation are re-ordered to follow alphabetic order:

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Oct 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review October 29, 2024 21:48
antonwolfy
antonwolfy reviewed Oct 29, 2024
View reviewed changes
antonwolfy
antonwolfy reviewed Oct 30, 2024
View reviewed changes
antonwolfy
antonwolfy reviewed Oct 30, 2024
View reviewed changes
antonwolfy
antonwolfy approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana No more comments from me

@vtavana vtavana merged commit b617d6c into master Oct 30, 2024
46 checks passed
@vtavana vtavana deleted the add_support_ndmin_for_array branch October 30, 2024 15:49
github-actions bot added a commit that referenced this pull request Oct 30, 2024
@github-actions
add support for kwarg ndmin for dpnp.array (#2135)
d70388a 
* add support for ndmin for dpnp.array

* update dpnp.ascontiguousarray and dpnp.asfortranarray

* update to fix issue for 0-d arrays

* address comments b617d6c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy