Skip to content

Add inplace matrix multiplication #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 5, 2024
Merged

Add inplace matrix multiplication #2147

merged 7 commits into from
Nov 5, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Nov 5, 2024 •
edited
Loading

This PR adds support for inplace matrix multiplication via the @= operator.

Also the PR refactors the tests from TestMatmulInvalidCases class and corrects type of exception raised for invalid value passed to axes keyword to report AxisError exception there.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Nov 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

vtavana
vtavana reviewed Nov 5, 2024
View reviewed changes
vtavana
vtavana reviewed Nov 5, 2024
View reviewed changes
vtavana
vtavana approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit 687b8ea into master Nov 5, 2024
46 checks passed
@antonwolfy antonwolfy deleted the add-inplace-matrix-multiplication branch November 5, 2024 22:33
github-actions bot added a commit that referenced this pull request Nov 5, 2024
@github-actions
Add inplace matrix multiplication (#2147)
8e02abc 
* Add support for inplace matrix multiplication

* Raise ValueError exception per axes keyword

* Add rendering documentation for reflected and inplace operations

* Exclude __reduce__ method from rendering documentation

* Align expection text for inplace matrix multiplication

* Split too long line 687b8ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vtavana