Skip to content

Properly set properties of group_load/group_store to striped #2238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2024
Merged

Properly set properties of group_load/group_store to striped #2238

merged 1 commit into from
Dec 17, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Dec 17, 2024 •
edited
Loading

PR proposes to pass striped property into group_load and group_store calls. It will help to fully replicate the legacy behavior of sub_group::load<vec_sz>and sub_group::store<vec_sz>.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Dec 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 65.082% (-0.004%) from 65.086%
when pulling 9fc0366 on set-striped-property-to-load-store
into 8f05542 on master.

vlad-perevezentsev
vlad-perevezentsev approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Thank you @antonwolfy !

@antonwolfy antonwolfy merged commit ea718e3 into master Dec 17, 2024
42 of 49 checks passed
@antonwolfy antonwolfy deleted the set-striped-property-to-load-store branch December 17, 2024 15:35
github-actions bot added a commit that referenced this pull request Dec 17, 2024
@github-actions
Properly set properties of group_load/group_store to striped (#2238)
ad5eaaf 
PR proposes to pass `striped` property into `group_load` and
`group_store` calls. It will help to fully replicate the legacy behavior
of `sub_group::load<vec_sz>`and `sub_group::store<vec_sz>`. ea718e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonwolfy @coveralls @vlad-perevezentsev