Skip to content

Add GitHub job with array API conformity run #2253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2025
Merged

Add GitHub job with array API conformity run #2253

merged 1 commit into from
Jan 14, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jan 10, 2025 •
edited
Loading

The PR adds a GitHub job to Conda package workflow with array API conformity.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jan 10, 2025
@antonwolfy antonwolfy force-pushed the add-github-ci-action-array-api-conformity branch from b74d93b to fe7f934 Compare January 10, 2025 11:50
@coveralls
Copy link
Collaborator

coveralls commented Jan 10, 2025 •
edited
Loading

Coverage Status

coverage: 70.943%. remained the same
when pulling 66aaf3d on add-github-ci-action-array-api-conformity
into ce3ef5e on master.

@antonwolfy antonwolfy force-pushed the add-github-ci-action-array-api-conformity branch 10 times, most recently from b1cb884 to 6ba60e2 Compare January 13, 2025 19:21
@antonwolfy antonwolfy marked this pull request as ready for review January 13, 2025 21:25
@antonwolfy antonwolfy force-pushed the add-github-ci-action-array-api-conformity branch from 0b6e354 to edadf0e Compare January 14, 2025 10:50
vlad-perevezentsev
vlad-perevezentsev reviewed Jan 14, 2025
View reviewed changes
@vlad-perevezentsev vlad-perevezentsev self-requested a review January 14, 2025 12:34
vlad-perevezentsev
vlad-perevezentsev approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Thank you @antonwolfy

@IntelPython IntelPython deleted a comment from github-actions bot Jan 14, 2025
@IntelPython IntelPython deleted a comment from github-actions bot Jan 14, 2025
@antonwolfy antonwolfy force-pushed the add-github-ci-action-array-api-conformity branch from adfab24 to 66aaf3d Compare January 14, 2025 13:59
@github-actions GitHub Actions
Copy link
Contributor

Array API standard conformance tests for dpnp=0.17.0dev4=py312he4f9c94_4 ran successfully.
Passed: 949
Failed: 0
Skipped: 51

@antonwolfy antonwolfy merged commit 498e705 into master Jan 14, 2025
58 of 59 checks passed
@antonwolfy antonwolfy deleted the add-github-ci-action-array-api-conformity branch January 14, 2025 15:44
github-actions bot added a commit that referenced this pull request Jan 14, 2025
@github-actions
Add GitHub job with array API conformity run (#2253)
bd9ca62 
The PR adds a GitHub job to `Conda package` workflow with array API
conformity. 498e705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonwolfy @coveralls @vlad-perevezentsev