Add mean keyword to dpnp.std and dpnp.var
#2271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Array API standard conformance tests for dpnp=0.17.0dev4=py312he4f9c94_19 ran successfully. |
antonwolfy
force-pushed
the
add-mean-keyword-to-std-var
branch
from
eb07397 to
0f463e9
Compare
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2271/index.html |
Disable pylint `duplicate-code` checker due to false-possitive issues reported.
|
Array API standard conformance tests for dpnp=0.17.0dev5=py312he4f9c94_19 ran successfully. |
antonwolfy
requested review from
AlexanderKalistratov,
vlad-perevezentsev and
vtavana
as code owners
vtavana
approved these changes
Jan 27, 2025
Co-authored-by: Vahid Tavanashad <[email protected]>
github-actions bot
added a commit
that referenced
this pull request
Jan 27, 2025
The PR proposes to add `mean` keyword argument to `dpnp.std`, `dpnp.var`, `dpnp.nanstd`, `dpnp.nanvar` functions and `dpnp.ndarray.std`, `dpnp.ndarray.var` methods. The keyword was introduced by NumPy 2.0 and intended to improve the performance: > Often when the standard deviation is needed the mean is also needed; the same holds for the variance and the mean. With the current code the mean is then calculated twice, this can be prevented if the functions calculating the variance or the standard deviation can use a precalculated mean This PR implements similar improvement in dpnp code. b72f953
6 tasks
antonwolfy
added a commit
that referenced
this pull request
Feb 3, 2025
`message-id` was added per #2271 to `mshick/add-pr-comment` steps in GitHub workflows, but one of the places was missing. The PR proposes to resolve that and to set the expected id, otherwise the affected step couldn't find the PR comment to update it (since `message-id: add-pr-comment` which it built by default differs).
github-actions bot
added a commit
that referenced
this pull request
Feb 3, 2025
`message-id` was added per #2271 to `mshick/add-pr-comment` steps in GitHub workflows, but one of the places was missing. The PR proposes to resolve that and to set the expected id, otherwise the affected step couldn't find the PR comment to update it (since `message-id: add-pr-comment` which it built by default differs). 2ac196c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR proposes to add
meankeyword argument todpnp.std,dpnp.var,dpnp.nanstd,dpnp.nanvarfunctions anddpnp.ndarray.std,dpnp.ndarray.varmethods.The keyword was introduced by NumPy 2.0 and intended to improve the performance:
This PR implements similar improvement in dpnp code.