Return named tuple for linalg functions per python array API #2276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
force-pushed
the
add-namedtuple-linalg
branch
from
b613691 to
e2e08fa
Compare
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
force-pushed
the
add-namedtuple-linalg
branch
from
d3036f9 to
5fc7c1a
Compare
|
Array API standard conformance tests for dpnp=0.17.0dev6=py312he4f9c94_20 ran successfully. |
antonwolfy
requested review from
AlexanderKalistratov,
vlad-perevezentsev and
vtavana
as code owners
vtavana
reviewed
Feb 10, 2025
vtavana
approved these changes
Feb 11, 2025
github-actions bot
added a commit
that referenced
this pull request
Feb 11, 2025
The PR proposes to return namedtuple for linalg functions: `qr`, `eig`, `eigh`, `svd` and `slogdet`. The namedtuple as a return type there is mandated to be compliant with python array API. The tests are updated to cover namedtyple as a return type of affected function. Also this PR requires to patch how napoleon extension from sphinx handles docstring description of namedtuple. The handling was align with NumPy approach. 898b6f2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR proposes to return namedtuple for linalg functions:
qr,eig,eigh,svdandslogdet.The namedtuple as a return type there is mandated to be compliant with python array API.
The tests are updated to cover namedtyple as a return type of affected function.
Also this PR requires to patch how napoleon extension from sphinx handles docstring description of namedtuple. The handling was align with NumPy approach.