Declaring required dependencies for wheel package #2283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Array API standard conformance tests for dpnp=0.17.0dev5=py312he4f9c94_5 ran successfully. |
antonwolfy
requested review from
AlexanderKalistratov,
vlad-perevezentsev and
vtavana
as code owners
vlad-perevezentsev
approved these changes
Jan 28, 2025
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2283/index.html |
|
Array API standard conformance tests for dpnp=0.17.0dev5=py312he4f9c94_9 ran successfully. |
github-actions bot
added a commit
that referenced
this pull request
Jan 28, 2025
The wheel package misses `requires_dist` entry in package info, but dpnp package has a decency on numpy and dpctl packages. The PR proposes to declare required dependencies in `setup.py`. Thus the package info of dpnp wheel package built in public CI will include: ```bash requires_python: >=3.9,<3.14 requires_dist: ['dpctl>=0.19.0dev0', 'numpy'] ``` and for internal CI: ```bash requires_python: >=3.9,<3.14 requires_dist: ['dpctl>=0.19.0dev0', 'numpy', 'dpcpp-cpp-rt', 'onemkl-sycl-blas', 'onemkl-sycl-dft', 'onemkl-sycl-lapack', 'onemkl-sycl-rng', 'onemkl-sycl-stats', 'onemkl-sycl-vm'] ``` Note that this PR also specifies a requirement on supported range of python versions. df307dd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wheel package misses
requires_distentry in package info, but dpnp package has a decency on numpy and dpctl packages.The PR proposes to declare required dependencies in
setup.py.Thus the package info of dpnp wheel package built in public CI will include:
and for internal CI:
Note that this PR also specifies a requirement on supported range of python versions.