Skip to content

Enable oneMath support for dpnp builds #2313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 14, 2025
Merged

Enable oneMath support for dpnp builds #2313

merged 6 commits into from
Feb 14, 2025

Conversation

vlad-perevezentsev
Copy link
Collaborator

Since oneMKL Interfaces has been renamed to oneMath this PR suggests adding automatic interface name detection for future releases while maintaining compatibility with the old unrenamed versions (onemkl)

Additionally changes oneMKL repository URL to oneMath

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Feb 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.17.0dev6=py312he4f9c94_18 ran successfully.
Passed: 992
Failed: 0
Skipped: 22

antonwolfy
antonwolfy reviewed Feb 13, 2025
View reviewed changes
antonwolfy
antonwolfy reviewed Feb 13, 2025
View reviewed changes
antonwolfy
antonwolfy reviewed Feb 13, 2025
View reviewed changes
antonwolfy
antonwolfy approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vlad-perevezentsev, LGTM!

@coveralls
Copy link
Collaborator

coveralls commented Feb 13, 2025 •
edited
Loading

Coverage Status

coverage: 71.737%. remained the same
when pulling 9151a9a on support_onemath
into 93535bd on master.

@vlad-perevezentsev vlad-perevezentsev merged commit 0d5ffad into master Feb 14, 2025
66 of 69 checks passed
@vlad-perevezentsev vlad-perevezentsev deleted the support_onemath branch February 14, 2025 15:01
github-actions bot added a commit that referenced this pull request Feb 14, 2025
@github-actions
Enable oneMath support for dpnp builds (#2313)
522a9fc 
Since `oneMKL Interfaces` has been renamed to `oneMath` this PR suggests
adding automatic interface name detection for future releases while
maintaining compatibility with the old unrenamed versions (onemkl)

Additionally changes `oneMKL` repository URL to `oneMath` 0d5ffad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vlad-perevezentsev @coveralls @antonwolfy