Fix issue gh-2311 #2314
Merged
Fix issue gh-2311 #2314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-perevezentsev
requested review from
antonwolfy,
AlexanderKalistratov and
vtavana
as code owners
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
|
Array API standard conformance tests for dpnp=0.17.0dev6=py312he4f9c94_22 ran successfully. |
antonwolfy
reviewed
Feb 14, 2025
antonwolfy
approved these changes
Feb 14, 2025
github-actions bot
added a commit
that referenced
this pull request
Feb 17, 2025
This PR suggests a solving #2311 When the input array is `(n, m)` or `(batch_size, n, m)` where m=1 `geqrf`/`geqrf_batch` call returns F-contig result array and `dpnp.empty_like()` is used to allocate `q` allocates F-contig array and this raises `ValueError` exception in `orgqr` and `ungqr` functions. Added `q` allocation always C-contig and updated tests 89cb658
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests a solving #2311
When the input array is
(n, m)or(batch_size, n, m)where m=1geqrf/geqrf_batchcall returns F-contig result array anddpnp.empty_like()is used to allocateqallocates F-contig array and this raisesValueErrorexception inorgqrandungqrfunctions.Added
qallocation always C-contig and updated tests