Align signature of dpnp.astype with Python array API
#2318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
requested review from
AlexanderKalistratov,
vlad-perevezentsev,
vtavana and
ndgrigorian
as code owners
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
|
Array API standard conformance tests for dpnp=0.17.0dev6=py312he4f9c94_36 ran successfully. |
vtavana
reviewed
Feb 19, 2025
Co-authored-by: Vahid Tavanashad <[email protected]>
vlad-perevezentsev
approved these changes
Feb 20, 2025
github-actions bot
added a commit
that referenced
this pull request
Feb 20, 2025
The PR is aimed to align signature of `dpnp.astype` function with Python array API where only `x` and `dtype` arguments are positional-only and other arguments are keyword-only. Also docstrings of `dpnp.astype` function and `dpnp.ndarray,astype` method are aligned and properly updated. And `dpnp.astype` function is moved to array creation namespace like NumPy has it. Additionally, docstring of `device` keyword is updated and aligned across all the functions description to have it described in a common way. af0fc93
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is aimed to align signature of
dpnp.astypefunction with Python array API where onlyxanddtypearguments are positional-only and other arguments are keyword-only.Also docstrings of
dpnp.astypefunction anddpnp.ndarray,astypemethod are aligned and properly updated. Anddpnp.astypefunction is moved to array creation namespace like NumPy has it.Additionally, docstring of
devicekeyword is updated and aligned across all the functions description to have it described in a common way.