Skip to content

Disable GitHub workflows to be run with python 3.13 #2322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Feb 18, 2025

There is currently no way to install dpnp with any numpy version > 2.0, because

  • there is no such version available on https://software.repos.intel.com/python/conda/ channel
  • numpy from conda-forge channel depends on BLAS libraries which has a runtime dependency mkl < 2025.0 (since BLAS packages with build number 29)

There is draft PR (gh-128) to build BLAS with MKL version 2025.0, but it is blocked due to MKL issue (gh-83).

Meanwhile there was conda-forge patch (gh-959) merged recently to add mkl < 2025.0 constraint to already published BLAS packaged on conda-forge with older build number.

DPNP package can't fulfill the requirement mkl < 2025.0, because it would mandate dpnp build pinning with DPC++ compiler 2024.2. While there were non-backward compatible changes between 2024.2 and 2025.x versions, that is dpnp built with 2024.2 compiler can not be installed with any DPC++ RT 2025.x version, but it is required since targeted by the upcoming release.

Thus the PR proposes to temporary disable or workaround all scenario where it is need to tests with numpy from conda-forge channel, including tests workflows for python 3.13 (per PR trigger and nightly) and workflow for testing of oneMath interfaces with the latest numpy.
The changes has to be rolled back once the above issues are resolved.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Feb 18, 2025
Copy link
Contributor

github-actions bot commented Feb 18, 2025

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

coveralls commented Feb 18, 2025

Coverage Status

coverage: 71.742%. remained the same
when pulling 90300cc on disable-github-workflows-with-python-3.13
into 1eb1592 on master.

Copy link
Contributor

github-actions bot commented Feb 18, 2025

Array API standard conformance tests for dpnp=0.17.0dev6=py312he4f9c94_22 ran successfully.
Passed: 992
Failed: 0
Skipped: 22

@antonwolfy
Copy link
Contributor Author

The night workflow passed here: https://github.com/IntelPython/dpnp/actions/runs/13398569974

Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit b09533e into master Feb 18, 2025
78 of 79 checks passed
@antonwolfy antonwolfy deleted the disable-github-workflows-with-python-3.13 branch February 18, 2025 21:24
github-actions bot added a commit that referenced this pull request Feb 18, 2025
There is currently no way to install dpnp with any numpy version > 2.0,
because
- there is no such version available on
`https://software.repos.intel.com/python/conda/` channel
- numpy from `conda-forge` channel depends on BLAS libraries which has a
runtime dependency `mkl < 2025.0` (since BLAS packages with build number
29)

There is draft PR
([gh-128](conda-forge/blas-feedstock#128)) to
build BLAS with MKL version 2025.0, but it is blocked due to MKL issue
([gh-83](conda-forge/intel_repack-feedstock#83)).

Meanwhile there was conda-forge patch
([gh-959](conda-forge/conda-forge-repodata-patches-feedstock#959))
merged recently to add `mkl < 2025.0` constraint to already published
BLAS packaged on `conda-forge` with older build number.

DPNP package can't fulfill the requirement `mkl < 2025.0`, because it
would mandate dpnp build pinning with DPC++ compiler 2024.2. While there
were non-backward compatible changes between 2024.2 and 2025.x versions,
that is dpnp built with 2024.2 compiler can not be installed with any
DPC++ RT 2025.x version, but it is required since targeted by the
upcoming release.

Thus the PR proposes to temporary disable or workaround all scenario
where it is need to tests with numpy from `conda-forge` channel,
including tests workflows for python 3.13 (per PR trigger and nightly)
and workflow for testing of oneMath interfaces with the latest numpy.
The changes has to be rolled back once the above issues are resolved. b09533e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants