Skip to content

Add an imp test for checking deposit collection and refunds #5102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Jun 2, 2025

Description

I wanted to convince myself that deposits are correctly collected an refunded, so I decided to add a test for it.

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@lehins lehins requested a review from a team as a code owner June 2, 2025 23:20
@lehins lehins requested a review from teodanciu June 2, 2025 23:21
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just some minor comments

@teodanciu teodanciu force-pushed the lehins/add-some-conway-deposit-tests branch from 9ccbc79 to f2fbabc Compare June 3, 2025 11:05
@lehins lehins force-pushed the lehins/add-some-conway-deposit-tests branch from 05b39d2 to e833e7c Compare June 3, 2025 20:17
@lehins lehins enabled auto-merge June 3, 2025 20:17
@lehins lehins merged commit f1987e2 into master Jun 3, 2025
125 of 126 checks passed
@lehins lehins deleted the lehins/add-some-conway-deposit-tests branch June 3, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants