This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Restore php 5.3 #159
Closed
Restore php 5.3 #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 7.4 deprecates the use of curly braces for array/string character access. See: https://wiki.php.net/rfc/deprecate_curly_braces_array_access
This will allow the Nette Tester dependency to download different versions depending on the PHP version the tests are run on.
Fixing issue with autoloader when executing from outside the source directory: php-parallel-lint#1
This is the same PR as previously pulled in PR JakubOnderka/PHP-Parallel-Lint 144 This makes the release zips used by Packagist smaller as it doesn't ship the test or config files which end-users shouldn't need anyway. Fixes 11
* Travis has removed support for `sudo: false`. See: https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration
Adding a build against `nightly` (PHP 8) which, for now, is allowed to fail. At this time, there is one unit test which fails `ParallelLint.lint.phpt method=testDeprecated`. This will need to be investigated over time. No urgency yet as it may be related to the Nette testing framework dependency and also PHP 8 is still in flux.
The current version is `3.5.4` released end of January 2020 and - aside from lots of bug fixes -, it includes compatibility with PHP 7.4. See: https://github.com/squizlabs/php_codesniffer/releases
The results of PHPCS run will be no different across PHP versions as all sniffs are unit tested against all supported PHP versions, so it is unnecessary to run it against every PHP version, just run it once per build. I've chosen to run it against PHP 7.4 as that's the fastest PHP version.
* Rename the ruleset to one which PHPCS will recognize automatically.
This means you no longer need to pass the `--standard` on the command-line.
* Use the `dist` extension to allow for devs to overload the ruleset file locally and gitignore the typical overload file names which are recognized by PHPCS by default.
* Ruleset/Travis: move command-line arguments to the project ruleset.
... and scan all PHP files, not just the files in `src`.
* Ruleset: also scan the `phpt` test files.
* Ruleset: enable parallel scanning.
* Ruleset: set the basepath for a cleaner output report.
* Ruleset: add the PHPCS XML scheme.
* Ruleset: selectively exclude the `skip-linting.php` file for the `Generic.PHP.NoSilencedErrors` rule.
Implementation of feature request 115. The user can now pass longer, multi-part extensions on the command-line and they will be respected. Example: `-e php,php.dist` Fixes 115
This should fix issue 33, by ignoring PHP startup errors completely for any PHP processes started from within the application.
PHP 8.0 has been branched off two months ago, so `nightly` is now PHP 8.1 and in the mean time PHP 8.0 was released last week. As of today, there is a PHP 8.0 image available on Travis. This PR adds a new build against PHP 8.0 to the matrix and, as PHP 8.0 has been released, that build is not allowed to fail.
This test is expected to throw a deprecation warning for the PHP4-style class constructor (method named the same as the class). In PHP 8, the deprecation warning is no longer thrown and PHP4-style constructor method are now treated as _normal_ methods. This fixes the test to have the correct expectations.
2 tasks
|
Wrong fork, corrected: php-parallel-lint/PHP-Parallel-Lint#51 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PHP 5.3 was removed, because Travis misconfiguration (32855d5). However, seems most PHP 5.3 code is still there. This will attempt to restore such compatibility.
Example:
As the version still won't be tested in CI, such use will be at their own risk, as this project doesn't CI test those versions.
PS: once this project CI is migrated to GitHub actions and setup-php, then PHP 5.3 support cab be enabled in Ci.