Skip to content

Fix custom type comment to use TypeFactory #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2018

Conversation

mordaroso
Copy link
Contributor

The documentation to add a custom type is wrong and the example does not work.

The method register is on TypeFactory and not on the Type module.

@senid231
Copy link
Member

@mordaroso nice catch
thanks

@senid231 senid231 merged commit fe506b5 into JsonApiClient:master May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants