Skip to content

#290 symbolize params keys on model initialize #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

senid231
Copy link
Member

@senid231 senid231 commented Oct 3, 2018

it will fix behavior when relationships and links are passed as symbol keys

related to #290

it will fix behavior when relationships and links are passed as symbol keys
Copy link
Collaborator

@gaorlov gaorlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call

@senid231 senid231 merged commit 5bc5f2c into JsonApiClient:master Oct 4, 2018
@senid231 senid231 mentioned this pull request Oct 5, 2018
@fzf
Copy link
Contributor

fzf commented Nov 1, 2018

This does not actually work, clear_changes_information removes the relationship. This is pattern matching on the setup mock. This should fix the issue: #317

@senid231
Copy link
Member Author

senid231 commented Nov 1, 2018

@fzf can you provide an example which doesn't work in your case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants