-
Notifications
You must be signed in to change notification settings - Fork 24
Implement value_gradient_and_hessian
#305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
value_gradient_and_hessian
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #305 +/- ##
==========================================
+ Coverage 96.11% 96.32% +0.20%
==========================================
Files 94 95 +1
Lines 4191 4294 +103
==========================================
+ Hits 4028 4136 +108
+ Misses 163 158 -5 ☔ View full report in Codecov by Sentry. |
@gdalle Thanks a lot for the work! I've already managed to test the new functionality with my projects and can confirm that it works. Unfortunately for the case of
Although the difference is small, I can't justify the migration of my code from |
Wait, we can do In any case, yes, a PR would be welcome with a custom dual number implementation. Let's start with a version that works in the scalar case, and then make it work in the vector case. |
Do you want to open said PR? I don't have complete confidence in my ability to get your code working on vectors, so it definitely would be great if you could help. |
Sure, I'll start it later today (also don't think I can get it working on vectors, but it's worth a try) |
DI source
value_gradient_and_hessian
for dense and sparse backendsextras
accordingly to prepare the gradient toomaybe_inner
,maybe_outer
andmaybe_dense_ad
logic to accommodate first-order backendsDI extensions
Add operator for:
DI docs
value_gradient_and_hessian
DIT source
value_gradient_and_hessian