-
Notifications
You must be signed in to change notification settings - Fork 6
[BREAKING] Remove the verbose
field, and use the Julia logging system instead
#23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING] Remove the verbose
field, and use the Julia logging system instead
#23
Conversation
@kleinhenz What are your thoughts on this PR? (I don't think we should merge this yet. It's a breaking change, so we can hold off on merging for now. But I figured it'd be good to get some feedback from you now.) |
Bump @kleinhenz - any thoughts on this PR? |
this makes sense to me. is |
Yep, exactly. By default, |
@kleinhenz Are there any other breaking changes that you anticipate making in the near future? If there aren't any other breaking changes coming up in the pipeline, I'd suggest that we merge this PR and register v1.0.0. |
@kleinhenz Bumping on this. Do you have any plans for any more breaking changes in the near future? |
No plans for more breaking changes. If this is ready I can merge and make a release |
Can you make one last 0.x release that includes #40? After that, we can merge this PR, and then release 1.0.0. |
ok a new release is in progress now |
Thanks so much! I see that v0.1.5 has now been tagged. I'll mark this PR as ready. |
Bump @kleinhenz. Now that v0.1.5 has been registered, shall we move forward with:
|
Important note: This is a breaking change, and thus will require a breaking release of SlurmClusterManager.jl.
The idea here is to get rid of the
.verbose
field, and instead log the message using@debug
. Then, if the user wants to turn on verbose logging, they just e.g. set theJULIA_DEBUG=SlurmClusterManager
environment variable.This allows the logging in this package to be composable with the rest of the
Logging
ecosystem in Julia.