fix: Ensure julia lib is always loaded as global #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed that this fixes juliacall on my M1 mac! Amazing work @gnuille. |
|
This doesn't appear to break anything on supported platforms. Great that it was such a simple fix to get it working on M1. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From issue #175 some users have noticed that there is an issue with running the Juliacall python module on Apple.
Investigating the issue was found that the julia library load was causing the error.
From my report and thanks to the Julia community they pointed out that the library should be loaded in RTLD_GLOBAL mode (JuliaLang/julia#45709)