Skip to content

Do not "help" the user by changing parameters #566

Open
@Nyholm

Description

@Nyholm

On 30+ places we have code like this:

if (!in_array($state, array('open', 'closed'))) {
    $state = 'open';
}

If the user misspelled the $state we should not help them. That may cause unpredicted actions. We should throw an exception or let the API call fail.

This is a BC break. I've marked it in milestone 3.0.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions