Skip to content

Refactor Repo Commits Compare method #602

Closed
@bobeagan

Description

@bobeagan

The compare method in https://github.com/KnpLabs/php-github-api/blob/master/lib/Github/Api/Repository/Commits.php currently accepts a mediaType parameter to change the Accept header. It seems like this should have a configure() method that handles this, which would follow the pattern of how it is handled elsewhere in the library.

This would be a breaking-change and should be targeted for the next major release.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions