Skip to content

Missing repository topics api endpoints #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2017

Conversation

acrobat
Copy link
Collaborator

@acrobat acrobat commented Dec 10, 2017

No description provided.

Copy link
Collaborator

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Just add some docs!

@@ -599,4 +601,20 @@ public function events($username, $repository, $page = 1)
{
return $this->get('/repos/'.rawurldecode($username).'/'.rawurldecode($repository).'/events', ['page' => $page]);
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding doc blocks here?

@Nyholm
Copy link
Collaborator

Nyholm commented Dec 12, 2017

Will do finish this tonight? ie, do you want this in 2.7?

@acrobat
Copy link
Collaborator Author

acrobat commented Dec 12, 2017

yes, give me a moment :)

@acrobat
Copy link
Collaborator Author

acrobat commented Dec 12, 2017

@Nyholm rebase and fixed the comments!

Copy link
Collaborator

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@Nyholm Nyholm merged commit 95e66ef into KnpLabs:master Dec 12, 2017
@acrobat acrobat deleted the repo-topics-api branch September 16, 2018 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants