Skip to content

Code improvements found with code analysis #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

acrobat
Copy link
Collaborator

@acrobat acrobat commented Dec 18, 2018

Various code improvement found by static code analysis

@acrobat acrobat force-pushed the code-improvement-static-code-analysis branch from c857154 to da2b5ec Compare December 18, 2018 19:06
@acrobat acrobat force-pushed the code-improvement-static-code-analysis branch from da2b5ec to 4b83145 Compare December 18, 2018 21:03
@acrobat acrobat closed this Jan 6, 2019
@acrobat acrobat reopened this Jan 6, 2019
@GrahamCampbell
Copy link
Contributor

Looks pretty solid to me. 👍

@acrobat acrobat merged commit 93c5d19 into KnpLabs:master Jan 28, 2019
@acrobat acrobat deleted the code-improvement-static-code-analysis branch January 28, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants