Drop old and unsupported php versions in v3 #782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm. I'd 👎 dropping PHP 7.1 just yet. It is not dead yet. |
|
@GrahamCampbell it's in security support only now and these changes are only for v3. But i'm ok to keep 7.1 for now! We can review it before we release 3.0 or drop it in some 3.x release! I've updated the PR! |
acrobat
force-pushed
the
drop-old-php-versions
branch
from
e3a577d to
5f94c15
Compare
|
As mentioned before we keep support for php 7.1 for now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.