Skip to content

Remove unnecessary rawurlencode in Repo->showById #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove unnecessary rawurlencode in Repo->showById #898

wants to merge 1 commit into from

Conversation

genintho
Copy link
Contributor

@genintho genintho commented Jul 3, 2020

GrahamCampbell
GrahamCampbell suggested changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎 This is already implemented on the latest 2.x. Your PR diff would degenerate to nothing on merge.

@GrahamCampbell
Copy link
Contributor

https://github.com/KnpLabs/php-github-api/blob/2.x/lib/Github/Api/Repo.php#L174

@genintho
Copy link
Contributor Author

genintho commented Jul 4, 2020

Race condition I guess. The code was changed 4 hours ago.

@genintho genintho closed this Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamCampbell GrahamCampbell GrahamCampbell requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@genintho @GrahamCampbell