Backport ResultPager changes to 2.x #945
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrobat
force-pushed
the
paginator-deprecations
branch
from
1a41692 to
6997513
Compare
|
@GrahamCampbell I've backported the resultpager changes from your PR to the 2.x branch. This makes for an easier upgrade path (with clear deprecations) + the improved resultpager can already be used in 2.x. Wdyt? |
acrobat
force-pushed
the
paginator-deprecations
branch
from
6997513 to
14e111a
Compare
Co-authored-by: Graham Campbell <[email protected]>
acrobat
force-pushed
the
paginator-deprecations
branch
from
14e111a to
d509e63
Compare
|
I don't think it makes sense to backport this, since this is actually breaking. Passing an ApiInterface to the pager now doesn't work unless it's one of the ones from this package. |
|
Hmm you are right, let's merge your PR and write an upgrade file with some info on th BC breaking changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the resultpager changes from #907