-
-
Notifications
You must be signed in to change notification settings - Fork 598
Prepare 3.0 release and remove remaining deprecated code #948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
## UPGRADE from 2.x to 3.0 | ||
|
||
### General | ||
|
||
* The `php-http/httplug` dependency requires is bumped to minimum ^2.1. | ||
* A client implementing `psr/http-client-implementation` is required. | ||
To upgrade your application (default install) switch from guzzle 6 to guzzle 7 (or replace `php-http/guzzle6-adapter` with any `psr/http-client-implementation`), see the install instructions in the [README file](README.md) | ||
* All previous deprecated code in version 2 is removed. | ||
* The following classes are now final | ||
* `Github\HttpClient\Message\ResponseMediator` | ||
* `Github\HttpClient\Plugin\Authentication` | ||
* `Github\HttpClient\Plugin\GithubExceptionThrower` | ||
* `Github\HttpClient\Plugin\History` | ||
* `Github\HttpClient\Plugin\PathPrepend` | ||
|
||
### Authetication methods | ||
|
||
* `Github\Client::AUTH_URL_TOKEN` use `Github\Client::AUTH_ACCESS_TOKEN` instead. | ||
* `Github\Client::AUTH_URL_CLIENT_ID` use `Github\Client::AUTH_CLIENT_ID` instead. | ||
* `Github\Client::AUTH_HTTP_TOKEN` use `Github\Client::AUTH_ACCESS_TOKEN` instead. | ||
* `Github\Client::AUTH_HTTP_PASSWORD` use `Github\Client::AUTH_ACCESS_TOKEN` instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,9 +12,8 @@ | |
* Add authentication to the request. | ||
* | ||
* @author Tobias Nyholm <[email protected]> | ||
* @final since 2.19 | ||
*/ | ||
class Authentication implements Plugin | ||
final class Authentication implements Plugin | ||
{ | ||
/** | ||
* @var string | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,9 +17,8 @@ | |
/** | ||
* @author Joseph Bielawski <[email protected]> | ||
* @author Tobias Nyholm <[email protected]> | ||
* @final since 2.19 | ||
*/ | ||
class GithubExceptionThrower implements Plugin | ||
final class GithubExceptionThrower implements Plugin | ||
{ | ||
/** | ||
* @return Promise | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,9 +11,8 @@ | |
* A plugin to remember the last response. | ||
* | ||
* @author Tobias Nyholm <[email protected]> | ||
* @final since 2.19 | ||
*/ | ||
class History implements Journal | ||
final class History implements Journal | ||
{ | ||
/** | ||
* @var ResponseInterface|null | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,9 +10,8 @@ | |
* Prepend the URI with a string. | ||
* | ||
* @author Tobias Nyholm <[email protected]> | ||
* @final since 2.19 | ||
*/ | ||
class PathPrepend implements Plugin | ||
final class PathPrepend implements Plugin | ||
{ | ||
/** | ||
* @var string | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.