Skip to content

Bugfix: Floating IP description which can be null #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2020
Merged

Bugfix: Floating IP description which can be null #36

merged 2 commits into from
Jan 31, 2020

Conversation

teyeheimans
Copy link
Contributor

This caused an TypeError: Argument 2 passed to FloatingIp::__construct() must be of the type string, null given.

This fix resolves that issue.

…TypeError: Argument 2 passed to FloatingIp::__construct() must be of the type string, null given.

This fix resolves that issue.
…s added in php 7.1. This package can be used since php version 7.0
@teyeheimans
Copy link
Contributor Author

I have removed the string type hint completely. This package uses php 7.0 or greater. Nullable types are added in php version 7.1, thus cannot be used.

@LKaemmerling LKaemmerling merged commit 3b22f7a into LKDevelopment:master Jan 31, 2020
@LKaemmerling
Copy link
Collaborator

Thank you! I will release this shortly.

@LKaemmerling LKaemmerling changed the title Bugfix for floating ip description which can be null. Bugfix: Floating IP description which can be null Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants