Skip to content

[feat] Dynamic import based on the available dependencies #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 9, 2021

Conversation

lolipopshock
Copy link
Member

@lolipopshock lolipopshock commented Sep 9, 2021

After this update, layout-parser would support the _LazyModule(originally from the transformers repo) that enables more flexible imports and dependency management.

For all OCR and LayoutModels, it may require additional dependencies installed beyond the base layout-parser implementation. Previously we resort to the method _import_module that binds the loading of the external dependencies to the specific classes. As a result, the import of the required dependencies should be handled within the classes, adding complexity to the model implementation.

In the new updates, the additional dependencies is handled at the library level: if the dependencies is not available, the actual python file for the corresponding class won't be imported and loaded as a part of the library. For example, if Detectron2 is not installed, after running import layoutparser as lp, the lp object even won't have the attribute Detectron2LayoutModel. This decouples the requirements with the corresponding class, and makes it easier to implement new models.

@lolipopshock lolipopshock merged commit 9b73ff1 into master Sep 9, 2021
@lolipopshock lolipopshock deleted the add-file-utils branch September 9, 2021 03:59
This was referenced Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant