outDir is not taking into account

[emmkimme]

Hi

likely my mistake, but I did not get it to work.

I have the following configuration (just keep relevant fields)

{
    "include": [
        "../../eikon-framework/src/**/*.ts"
    ],
    "compilerOptions": {
        "baseUrl": ".",
        "paths": {
            "df-core/*": ["./build/df-core/*"],
            "*": [
                "./node_modules/*",
                "./node_modules/@types/*"
            ]
        },
        "rootDir": "../../eikon-framework/src",
        "outDir": "./build/eikon-framework"
    }
}

I have the following file:
../../src/eikon-framework/src/auth/auth-impl.ts
import { GetElectronEnvironment } from 'df-core/env';

after the compilation in the outDir folder I have
[outDir]/eikon-framework/auth/auth-impl.js
const env_1 = require("../../../products/workspace/build/df-core/env/index");

It seems the resolution has been done from the original location of TS file and not from the output location of JS file.
With "df-core/": ["./build/df-core/"] and outDir = ./build/eikon-framework/auth/auth-impl.js

I would expect
const env_1 = require("../../df-core/env/index");

Could you help me please

Thanks

[danielpza]

Perhaps the virtual directories would help in this case

[emmkimme]

Thanks for your prompt answer
I once tried
{ "transform": "typescript-transform-paths", "useRootDirs": true },

"rootDirs": ["./build/df-core/*"],

but same result.

Is my assumptions good ?, I mean, looking at outDir + df-core path, it sounds logic to have
'const env_1 = require("../../df-core/env/index");'

Typescript compiles with such configuration and it works with tcspaths (no offense ;-)) but I much prefer your plugin.

[emmkimme]

Looking at your code and debugging the plugin, I found a way to deal with rootDirs.

{
    "include": [
        "../../eikon-framework/src/**/*.ts"
    ],
    "compilerOptions": {
        "rootDirs": ["./build/", "../../eikon-framework"],
        "baseUrl": ".",
        "paths": {
            "df-core/*": ["./build/df-core/*"],
            "*": [
                "./node_modules/*",
                "./node_modules/@types/*"
            ]
        },
        "rootDir": "../../eikon-framework/src",
        "outDir": "./build/eikon-framework"
    }
}

I'm wondering if we could have another way just using 'paths', 'rootDir' and 'outDir' to achieve the same. I have the feeling to duplicate the information.

Feel free to close this issue and thanks for your help and for this plugin.

[danielpza]

Glad you find your solution. I'll keep the issue open in case someone wants to chime in.

[nonara]

@emmkimme I'd like to have a look into this. Would you mind making a reproduction repo / branch for me to try it? I'm not entirely sure I see what's happening here, but it looks like an issue of tsconfig being in a totally separate location from the source files. You might be right that this shouldn't be the standard behaviour. I'd need an example to see what's going on, though.

[kainstar]

I have same problem, I think the reason is transform plugin resolve relative path form source file rather than this output file, but sometimes we will emit files into the different level dir, that's why the final relative path is wrong.

I see this issue has tagged Bug label, is there has someone trying to solve it?

[couellet]

I'm having a similar issue, here's my tsconfig.json file:

{
    "compilerOptions": {
        "target": "es5",
        "module": "esnext",
        "moduleResolution": "node",
        "declaration": true,
        "outDir": "dist",
        "strict": true,
        "lib": ["es5", "ES2015.Promise", "DOM"],
        "stripInternal": true,
        "sourceMap": true,
        "strictNullChecks": true,
        "esModuleInterop": true,
        "noEmitHelpers": true,
        "importHelpers": true,
        "allowSyntheticDefaultImports": true,
        "allowJs": true,
        "experimentalDecorators": true,
        "rootDirs": [".", "./dist"],
        "baseUrl": "./src",
        "rootDir": ".",
        "paths": {
            "@/*": [
                "./*"
            ]
        },
        "plugins": [
            { "transform": "typescript-transform-paths", "useRootDirs": true, "afterDeclarations": true }
          ]
    },
    "include": [
        "src/**/*.ts"
    ]
}

I just added rootDirs and rootDir, but it didn't change anything. I have the following file tree:

| - 📂src
| - 📂dist
| - 📃 tsconfig.json

So my compiled files are in the dist folder but it seems that the transformer doesn't run on these, paths remain absolute.

[danielpza]

@couellet I think you need 2 entries in the plugin section for the transformer to actually work:

https://github.com/LeDDGroup/typescript-transform-paths#example-config

    "plugins": [
      { "transform": "typescript-transform-paths", "useRootDirs": true },
      { "transform": "typescript-transform-paths", "useRootDirs": true, "afterDeclarations": true }
    ]

[couellet]

@danielpza that was it! Thank you so much.

[nonara]

I see this issue has tagged Bug label, is there has someone trying to solve it?

I will, but I need a reproduction