Custom file name template

[fhyoga]

考虑支持自定义的文件名吗？

比如 中文版生成的文件名含有中文，import一个中文文件，感觉不是很靠谱，所以每次都要手动修改。

我觉得，文件名最好支持模版插值，可以取{tag}{difficulty}等几个meta信息填充，这样也可以满足不同人的需求。

[jdneo]

@poppinlp Guessing this might be a regression in #149

If the user is using Chinese version LeetCode, the file name we generated will contain Chinese

[fhyoga]

@poppinlp Guessing this might be a regression in #149

If the user is using Chinese version LeetCode, the file name we generated will contain Chinese

I think these two issues are not the same function, maybe you didn't understand what I meant. I am suggesting to add a configuration item, just like outputFolder, does not affect the reading of local files.

[fhyoga]

Setting Name	Description	Default Value
fileName	The name of the generated file;{id}-{difficulty}-{tag}-{name}	{id}.{name}.{ext}

like this? @jdneo

[poppinlp]

@jdneo
I have not tested on the Chinese version LeetCode. That's my fault. I'll fix it and think about the test cases.

@Dec-F
Yep. You are talking about a different feature. I think I get your point.
What's your option about this? @jdneo I think this feature is reasonable but not high priority.

[fhyoga]

If this feature is necessary, I will submit a PR tomorrow or weekend. What do you think? @jdneo @poppinlp

[jdneo]

@poppinlp Not your fault, we all missed that part, It's great if this can be fixed.

@Dec-F PR is welcome, you can send out it whenever you want.

[poppinlp]

@jdneo I've sent a PR to fix the Chinese file name issue.

@jdneo @Dec-F Here maybe a plan to support the file name pattern:

We could pass the whole config into the genFileName function instead of the only endpoint right now to avoid too many params. And then generate the file name by the pattern in the setting. And don't forget to update the documents after that.

The variable in pattern could be:

• id
• name
• difficulty
• ext
• companies(join the array in kebabcase?)
• tags(join the array in kebabcase?)

[jdneo]

For a certain problem, it may belong to multiple companies and tags, how to handle this scenario?

@Dec-F One thing I missed is that we prefer to discussing the implementation before sending the PR, free feel to share your thoughts.

[poppinlp]

On the one side, if we wanna support company and tag, of course, the tags and companies could be an array. So we may just merge the array items with a separate symbol such as underscore, dash, e.t.c.

On the other side, I think the first question is what should we support company and tag? For me, there's no such need. But maybe there could be a situation for others that they wanna grep the files by company name or tag. I'm not really sure about this. So I listed them and look forward to opinions.

BTW, there may be some risks that if the tags of a problem changed then the local source code could be missed.

[fhyoga]

I think there are two ways to deal with it.

1. Let the user choose. Treat like this
2. fileName option Support function, handed to user programming

What do you think?

[jdneo]

@Dec-F Will your request get satisfied if we implement the comment here: #119 (comment)