Skip to content

Add side mode to webview #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 22, 2019
Merged

Add side mode to webview #271

merged 11 commits into from
Apr 22, 2019

Conversation

Vigilans
Copy link
Contributor

Walkthrough:
WalkThrough

ShowProblem command also benefits from it:
ShowProblem

Solution weview always follows the state of preview:
Preview   Solution

What if the title doesn't change (this is on a wide-screen computer):
WhatIf

@Vigilans Vigilans requested a review from jdneo April 16, 2019 12:14
@jdneo
Copy link
Member

jdneo commented Apr 16, 2019

Thanks, I'll take a look tomorrow.

@Vigilans
Copy link
Contributor Author

enableSideMode walkthrough:
enableSideMode

Copy link
Member

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Would you mind also update the document(about the setting: leetcode.enableSideMode) in this PR as well?

@jdneo jdneo added this to the 0.13.4 milestone Apr 22, 2019
@Vigilans
Copy link
Contributor Author

Document added.

@jdneo jdneo merged commit 52a84d3 into master Apr 22, 2019
@Vigilans Vigilans deleted the vigilans/webview-sidemode branch April 22, 2019 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants