-
Notifications
You must be signed in to change notification settings - Fork 664
Centralize the logic about wsl #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @purocean, As we have discussed before. We can have some further improvement about the WSL support. During my own experience, the main problems of current implementation are:
So this is the reason I create a new class: Very appreciated if you can help review this PR if you have time. Since this feature is originally contributed by you. 😄 |
@jdneo OK, I'll take a look. |
@jdneo
It occurs an error in my machine. https://github.com/jdneo/vscode-leetcode/blob/8c52f42f37bcc48b0f79210545169e629ec456d3/src/utils/nodeUtils.ts#L10 Looks like have no specific treatment for WSL. |
@purocean Nice finding! I'll fix it. |
@purocean Updated. Please have a try when you have time. |
@jdneo
|
@purocean Emm, I'm sorry. Anything wrong with "Submitting to LeetCode..."? |
@jdneo |
Haha, got it. We can revisit the wording issue if we get user feedbacks in the future. |
fix #48
fix #54