Record.convert_dtype should fail if expected data is missing #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If physical is true, and smooth_frames is false, and e_p_signal is None, this function should raise an exception. It should not silently modify p_signal instead. The previous code didn't make any sense: p_signal is a numpy array, so you can't change its data type by assigning to a slice of it, and even if that conversion were possible, the slicing was being done along the wrong axis. This reverts a dubious change in commit 725e7a6, which seems unrelated to the rest of that commit.
|
(pull #244 is where this was introduced) |
|
Looks good to me, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not directly related to other issues surrounding
smooth_frames, but a minor bug that probably doesn't affect anyone at present.Record.convert_dtypecan be used to change the storage format of the signal array(s). (It's unlikely that applications will ever use this function directly and it's not included in the package documentation.)However, if
convert_dtypeis called withphysical=Trueandsmooth_frames=False, it should convert the data type(s) ofe_p_signal. It shouldn't try to modifyp_signalin this case (and the previous code would not have worked correctly either.) If you ask to convert the data type ofe_p_signal, ande_p_signalis None, this should raise an exception.