install latest pip, add setuptools_scm to BUILD_DEPENDS #62
Conversation
.travis.yml
Outdated
| @@ -68,13 +68,16 @@ before_install: | |||
| - python -c "import fcntl; fcntl.fcntl(1, fcntl.F_SETFL, 0)" | |||
| - CONTAINER="wheels"; # pre-relesae | |||
| - BUILD_COMMIT=$BUILD_COMMIT; | |||
| - BUILD_DEPENDS="$NP_BUILD_DEP Cython==0.28.2" | |||
| # add setuptools_scm here as WAR for https://github.com/pypa/packaging-problems/issues/134 with Python 3.5 | |||
| - BUILD_DEPENDS="$NP_BUILD_DEP Cython==0.28.2 setuptools_scm" | |||
There was a problem hiding this comment.
Should setuptools_scm and the pip (re?)install only be done for the 3.5 build?
There was a problem hiding this comment.
is it relevant that pandas requires cython 0.29.13?
There was a problem hiding this comment.
This is on the master, which sets the BUILD_COMMIT=v0.25.1 which allowed older Cythons.
There was a problem hiding this comment.
yeah @TomAugspurger its only needed for the mac 3.5 build. I've added some more explanation in pandas-dev/pandas#28954 (comment).
There was a problem hiding this comment.
Yes @TomAugspurger - it turns out thatmultibuild already installs the latest pip for mac https://github.com/matthew-brett/multibuild/blob/f0bff09b0c03ed5325cbcbef135b16b2b9162d53/osx_utils.sh#L306. But even if it didnt, looking at the logs, the version that travis preinstalls is 10.0.1 which would be more than sufficient.
|
Thanks! |
* install latest pip, add setuptools_scm to BUILD_DEPENDS * remove comments * pre-install setuptools_scm only for mac 3.5 build (cherry picked from commit 1508d26)
* install latest pip, add setuptools_scm to BUILD_DEPENDS * remove comments * pre-install setuptools_scm only for mac 3.5 build (cherry picked from commit 1508d26)
resolves pandas-dev/pandas#28954