Execute UNLISTEN unconditionally in connection reset query #698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `UNLISTEN` in connection release is guarded by an expensive PL/pgSQL block, because historically PostgreSQL did not allow `UNLISTEN` on a hot standby node. This has since changed, and `UNLISTEN` is allowed in PostgreSQL 9.4.21+, 9.5.16+, 9.6.12+, 10.7+, 11.2+, and versions 12 and newer. If this change breaks your setup, upgrade your server. The removal of the PL/pgSQL guard reduces the `acquire`/`release` overhead by over 50%. Upstream discussion: https://postgr.es/m/CADT4RqCf2gA_TJtPAjnGzkC3ZiexfBZiLmA-mV66e4UyuVv8bA@mail.gmail.com Fixes: #648
|
Shortest-lived PR ever 😆 |
|
I didn't realize the work was already done in #648. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
UNLISTENin connection release is guarded by anexpensive PL/pgSQL block, because historically PostgreSQL
did not allow
UNLISTENon a hot standby node. This has sincechanged, and
UNLISTENis allowed in PostgreSQL 9.4.21+, 9.5.16+,9.6.12+, 10.7+, 11.2+, and versions 12 and newer. If this change
breaks your setup, upgrade your server.
The removal of the PL/pgSQL guard reduces the
acquire/releaseoverheadby over 50%.
Upstream discussion: https://postgr.es/m/CADT4RqCf2gA_TJtPAjnGzkC3ZiexfBZiLmA-mV66e4UyuVv8bA@mail.gmail.com
Fixes: #648