-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix type errors, enable type checking for mobject/geometry and add typings for the transformation functions #4228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
def scale( | ||
self, | ||
scale_factor: float, | ||
*, | ||
about_point: Point3DLike | None = None, | ||
about_edge: Vector3D | None = None, | ||
) -> Self: |
Check notice
Code scanning / CodeQL
Mismatch between signature and use of an overridden method Note
call
method VMobject.scale
Overridden method signature does not match
call
method VMobject.scale
Overridden method signature does not match
call
method VMobject.scale
Overridden method signature does not match
call
method VMobject.scale
Overridden method signature does not match
call
method VMobject.scale
This pull request contains several improvements. This can make it harder to get an overview of what is actually changed for each contribution. I have noted the following contributions. Related to type annotations:
General code cleanup:
Potential breaking changes:
All changes related to type annotations and the general code cleanup looks good to me. Regarding the potential breaking changes I hope that one of the other maintainers will take a look at that. |
Overview: What does this pull request change?
Mypy type checking number of errors:
manim/geometry
: 92Links to added or changed documentation pages
Reviewer Checklist