Implement Exception Safety #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-F-Bryan
force-pushed
the
exception-safety
branch
from
59c5c1a to
25bbf9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the code that would be required to implement "poisoning" in the face of panics, which we need because the FFI functions catch panics and let the
*mut FileHandlebe used later.Unfortunately we need to add a
poisonedflag which is checked in each vtable method instead of just FFI functions. Otherwise it is possible for a panic to occur when calling a function likeffi::file_handle_write()and the writer's internals get corrupted, then you pass the*mut FileHandleto Rust and try to callOwnedFileHandle'swrite()method, letting you observe a FUBAR writer.Fixes #1.